feat: new modal on Private Apps install #33275

MartinSchoeler · 2024-09-12T18:15:24Z

Proposed changes (including videos or screenshots)

Adds a new button on the header of the private apps when the private apps limit is 0 and adds a new modal as well

Issue(s)

PASLR-14

Steps to test or reproduce

Further comments

dionisio-bot · 2024-09-12T18:15:27Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2024-09-12T18:15:28Z

🦋 Changeset detected

Latest commit: d9b27dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/i18n
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/ui-client	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-12T18:19:22Z

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33275/
on branch `gh-pages` at 2024-09-18 17:02 UTC

codecov · 2024-09-12T18:23:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (abe1570) to head (9c6532b).

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #33275   +/-   ##
==============================================
  Coverage          76.91%   76.91%           
==============================================
  Files                378      378           
  Lines              19035    19035           
  Branches            4905     4905           
==============================================
  Hits               14640    14640           
  Misses              4168     4168           
  Partials             227      227

Flag	Coverage Δ
unit	`76.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

tiagoevanp

Can you test the UI button?

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

* feat: New empty state for upgrading private Apps * chore: Change Marketplace info modal text (#33239) * feat: New tooltips and color behavior for private apps bar (#33243) * feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md * feat: new modal on Private Apps install (#33275) * feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md * chore: change grandfathered modal text (#33291) * chore: Use apps provider to check maxPrivateApps * fix: adds minor fixes to UI and changes requested on review * Update changeset * Replace negative boolean * Refactor `AppsUsageCard` * Add unit test for `AppsUsageCard` * Add unit test for `PrivateEmptyState` * Add unit test for `EnabledAppsCount` * Move tooltip logic away from `useAppsCountQuery` --------- Co-authored-by: Lucas Pelegrino <lucas.pelegrino@icloud.com> Co-authored-by: Tasso <tasso.evangelista@rocket.chat>

MartinSchoeler added 3 commits September 16, 2024 09:21

feat: new modal on Private Apps install

b9344a5

add more variations

9a2f61f

Create eleven-rockets-hug.md

16f7ad8

MartinSchoeler force-pushed the upgrade-sub branch from f9bd118 to 16f7ad8 Compare September 16, 2024 12:22

MartinSchoeler changed the base branch from develop to release-7.0.0 September 16, 2024 12:22

MartinSchoeler added this to the 7.0 milestone Sep 16, 2024

Merge branch 'release-7.0.0' into upgrade-sub

9c6532b

MartinSchoeler marked this pull request as ready for review September 17, 2024 16:37

MartinSchoeler requested a review from a team as a code owner September 17, 2024 16:37

tiagoevanp requested changes Sep 17, 2024

View reviewed changes

MartinSchoeler removed this from the 7.0 milestone Sep 18, 2024

MartinSchoeler changed the base branch from release-7.0.0 to unsuported-marketplace September 18, 2024 16:47

Merge branch 'unsuported-marketplace' into upgrade-sub

d9b27dc

MartinSchoeler merged commit 265e7d3 into unsuported-marketplace Sep 18, 2024
6 of 8 checks passed

MartinSchoeler deleted the upgrade-sub branch September 18, 2024 16:56

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: new modal on Private Apps install (#33275)

d86b007

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: new modal on Private Apps install (#33275)

3edd654

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: new modal on Private Apps install (#33275)

ddc0886

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: new modal on Private Apps install (#33275)

e634489

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

tassoevan pushed a commit that referenced this pull request Sep 30, 2024

feat: new modal on Private Apps install (#33275)

215fc8d

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

tassoevan pushed a commit that referenced this pull request Oct 1, 2024

feat: new modal on Private Apps install (#33275)

a5602d9

* feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new modal on Private Apps install #33275

feat: new modal on Private Apps install #33275

MartinSchoeler commented Sep 12, 2024 •

edited

Loading

dionisio-bot bot commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading

tiagoevanp left a comment

feat: new modal on Private Apps install #33275

feat: new modal on Private Apps install #33275

Conversation

MartinSchoeler commented Sep 12, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented Sep 12, 2024 • edited Loading

changeset-bot bot commented Sep 12, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Sep 12, 2024 • edited Loading

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

tiagoevanp left a comment

Choose a reason for hiding this comment

MartinSchoeler commented Sep 12, 2024 •

edited

Loading

dionisio-bot bot commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading