Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new permission for freeswitch voip endpoints #33310

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Sep 17, 2024

Proposed changes (including videos or screenshots)

Team Collab VoIP was using the same permissions as Omnichannel's VoIP; This PR adds new permissions to separate the two features.

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 0731b46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Sep 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Sep 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 16:04 UTC

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/freeswitch-6-12@8e79be5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/freeswitch-6-12   #33310   +/-   ##
=======================================================
  Coverage                        ?   59.69%           
=======================================================
  Files                           ?     2553           
  Lines                           ?    62816           
  Branches                        ?    14107           
=======================================================
  Hits                            ?    37499           
  Misses                          ?    22910           
  Partials                        ?     2407           
Flag Coverage Δ
unit 76.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review September 18, 2024 13:24
@pierre-lehnen-rc pierre-lehnen-rc merged commit ae54a18 into feat/freeswitch-6-12 Sep 18, 2024
51 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/freeswitch-permissions branch September 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants