-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: removed mailer.sendMail mailer:unsubscribe methods #33358
chore!: removed mailer.sendMail mailer:unsubscribe methods #33358
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c95cffb The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
54f1194
to
fe17da2
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33358 +/- ##
=================================================
- Coverage 74.80% 74.79% -0.02%
=================================================
Files 468 467 -1
Lines 20678 20641 -37
Branches 5275 5262 -13
=================================================
- Hits 15469 15439 -30
+ Misses 4594 4590 -4
+ Partials 615 612 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
e9bbdbd
to
cb512e1
Compare
fe17da2
to
03e6515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changeset to declare what is happening here? If we are removing some methods (sound like a deprecation) it's better to have something in the release changelog...
The merge-base changed after approval.
50abbe6
to
bf02ce5
Compare
ec33e68
to
d1aa5f9
Compare
d1aa5f9
to
374979f
Compare
d5c0cc3
to
77ed8d5
Compare
fb25552
to
99c04b1
Compare
bfefe41
to
204272c
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
77ed8d5
to
1c21662
Compare
Proposed changes (including videos or screenshots)
removed mailer.sendMail mailer:unsubscribe methods as they have been replaced by mailer and mailer.unsubscribe endpoints
Issue(s)
Steps to test or reproduce
Further comments
CORE-358
CORE-359