Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removed mailer.sendMail mailer:unsubscribe methods #33358

Merged

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Sep 25, 2024

Proposed changes (including videos or screenshots)

removed mailer.sendMail mailer:unsubscribe methods as they have been replaced by mailer and mailer.unsubscribe endpoints

Issue(s)

Steps to test or reproduce

Further comments

CORE-358
CORE-359

Copy link
Contributor

dionisio-bot bot commented Sep 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: c95cffb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin changed the base branch from develop to release-7.0.0 September 25, 2024 13:48
@abhinavkrin abhinavkrin force-pushed the chore/removed-Mailer.sendMail-Mailer.unsubscribe branch from 54f1194 to fe17da2 Compare September 25, 2024 13:49
Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33358/
on branch gh-pages at 2024-10-15 22:06 UTC

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (6d0e099) to head (c95cffb).
Report is 5 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33358      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.02%     
=================================================
  Files                468      467       -1     
  Lines              20678    20641      -37     
  Branches            5275     5262      -13     
=================================================
- Hits               15469    15439      -30     
+ Misses              4594     4590       -4     
+ Partials             615      612       -3     
Flag Coverage Δ
unit 74.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as ready for review September 25, 2024 16:31
@abhinavkrin abhinavkrin requested review from a team as code owners September 25, 2024 16:31
@abhinavkrin abhinavkrin force-pushed the chore/removed-Mailer.sendMail-Mailer.unsubscribe branch from fe17da2 to 03e6515 Compare September 25, 2024 16:32
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset to declare what is happening here? If we are removing some methods (sound like a deprecation) it's better to have something in the release changelog...

tiagoevanp
tiagoevanp previously approved these changes Sep 26, 2024
@ggazzo ggazzo dismissed tiagoevanp’s stale review September 27, 2024 18:05

The merge-base changed after approval.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 50abbe6 to bf02ce5 Compare September 27, 2024 22:43
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 9, 2024
@ggazzo ggazzo force-pushed the chore/removed-Mailer.sendMail-Mailer.unsubscribe branch from d5c0cc3 to 77ed8d5 Compare October 11, 2024 16:32
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from fb25552 to 99c04b1 Compare October 11, 2024 18:01
@ggazzo ggazzo requested a review from a team as a code owner October 11, 2024 18:01
@ggazzo ggazzo force-pushed the release-7.0.0 branch 5 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@MartinSchoeler MartinSchoeler force-pushed the chore/removed-Mailer.sendMail-Mailer.unsubscribe branch from 77ed8d5 to 1c21662 Compare October 15, 2024 18:37
@scuciatto scuciatto added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo added this to the 7.0 milestone Oct 16, 2024
@ggazzo ggazzo merged commit fe627b4 into release-7.0.0 Oct 16, 2024
51 checks passed
@ggazzo ggazzo deleted the chore/removed-Mailer.sendMail-Mailer.unsubscribe branch October 16, 2024 16:48
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants