Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove livechat:getCustomFields method #33371

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Sep 26, 2024

Proposed changes (including videos or screenshots)

This PR removes deprecated livechat:getCustomFields method. Moving forward use the livechat/custom-fields endpoint.

Issue(s)

Steps to test or reproduce

Further comments

CORE-364

@abhinavkrin abhinavkrin requested a review from a team as a code owner September 26, 2024 09:00
Copy link
Contributor

dionisio-bot bot commented Sep 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 43e704e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin marked this pull request as draft September 26, 2024 09:02
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-01 18:42 UTC

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (c9a263c) to head (43e704e).
Report is 6 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33371   +/-   ##
==============================================
  Coverage          75.32%   75.32%           
==============================================
  Files                383      383           
  Lines              19383    19383           
  Branches            4980     4980           
==============================================
  Hits               14601    14601           
  Misses              4212     4212           
  Partials             570      570           
Flag Coverage Δ
unit 75.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as ready for review September 26, 2024 10:16
@ggazzo ggazzo requested review from a team as code owners September 27, 2024 18:05
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@ggazzo ggazzo force-pushed the chore/remove-livechat-getCustomFields-method branch from fa3a5a3 to c89a926 Compare October 1, 2024 01:09
@ggazzo ggazzo added this to the 6.13 milestone Oct 1, 2024
@ggazzo ggazzo added feat: message stat: QA assured Means it has been tested and approved by a company insider labels Oct 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 1, 2024
ggazzo
ggazzo previously approved these changes Oct 1, 2024
@ggazzo ggazzo modified the milestones: 6.13, 7.0 Oct 1, 2024
@ggazzo ggazzo merged commit fc48ea6 into release-7.0.0 Oct 1, 2024
50 checks passed
@ggazzo ggazzo deleted the chore/remove-livechat-getCustomFields-method branch October 1, 2024 18:42
ggazzo added a commit that referenced this pull request Oct 8, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
abhinavkrin added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 15, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
This was referenced Oct 20, 2024
abhinavkrin added a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants