fix: Blank selected department when selecting out of range #33386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The the Oc current chats departments filter uses "on scroll" pagination. If a user selects a department that isn’t within the first 25 departments listed, the selection will appear blank after refreshing the page. This happens because the `PaginatedSelectFiltered` component cannot find the selected department in the paginated options list due to it not being part of the initially fetched list of departments.
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e5d5157 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33386 +/- ##
========================================
Coverage 58.58% 58.59%
========================================
Files 2737 2737
Lines 65677 65714 +37
Branches 14824 14826 +2
========================================
+ Hits 38478 38505 +27
- Misses 24420 24430 +10
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
requested changes
Sep 30, 2024
…2e tests Added tests to verify when the useDepartmentsList function should normalize the departments list for the current chats department filter. Also added an end-to-end test to validate the use of localStorage in the department filter.
Hey @KevLehman, talking to the frontend folks we concluded that it would be better to test this specific behavior through unit tests of the |
KevLehman
previously approved these changes
Oct 2, 2024
KevLehman
previously approved these changes
Oct 7, 2024
aleksandernsilva
requested changes
Oct 7, 2024
apps/meteor/client/components/Omnichannel/hooks/useDepartmentsList.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/normalizeDepartments.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/normalizeDepartments.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/normalizeDepartments.ts
Outdated
Show resolved
Hide resolved
aleksandernsilva
requested changes
Oct 7, 2024
apps/meteor/client/components/Omnichannel/hooks/useDepartmentsList.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/utils/normalizeDepartments.ts
Outdated
Show resolved
Hide resolved
aleksandernsilva
previously approved these changes
Oct 8, 2024
aleksandernsilva
approved these changes
Oct 8, 2024
rique223
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The Omnichannel current chats departments filter uses "on scroll" pagination (it fetches a list of the 25 first departments and loads more items every 25 items that the user scrolls down). If a user selects a department that isn’t within the first 25 departments listed, the selection will appear blank after refreshing the page. This happens because the
PaginatedSelectFilteredcomponent cannot find the selected department in the paginated options list due to it not being part of the initially fetched list of departments. This PR adds a "normalization" function to the listing of departments that will add the missing department to the initial list so the component can correctly show the previously selected department.Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: SUP-675