fix!: Private apps are always auto enabled when updated

[matheusbsilva137]

Proposed changes (including videos or screenshots)

• Stop auto-enabling private apps when they are updated. Instead, only try to startup the updated app (and consequently, auto-enable it) when it was already in an enabled status before the update.

Issue(s)

Steps to test or reproduce

Go to Marketplace > Private apps and try updating a disabled private app in CE (eg by uploading its file once again).
Current behavior: the updated app will be enabled after the update, regardless of any condition.
Expected behavior: the app should only be enabled if it was already enabled before the update (so that license restriction are also followed accordingly)

Further comments

PASLR-25

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 48ed6c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/apps-engine	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-03 19:26 UTC

[matheusbsilva137]

Waiting for #33399 to be merged to open this PR (so that E2E tests work properly)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (09d45b8) to head (48ed6c6).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-7.0.0   #33417      +/-   ##
=================================================
- Coverage          75.66%   75.32%   -0.34%     
=================================================
  Files                430      383      -47     
  Lines              19904    19383     -521     
  Branches            5079     4980      -99     
=================================================
- Hits               15060    14601     -459     
+ Misses              4273     4212      -61     
+ Partials             571      570       -1     

Flag	Coverage Δ
unit	75.32% <ø> (-0.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.