Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: renamed voip-related settings #33434

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 3, 2024

Proposed changes (including videos or screenshots)

With the introduction of voip for team collaboration we are changes some settings to improve clarity.

Changes are as follows:

  • Voice channel -> Omnichannel voice channel (VoIP)
  • VoIP for TeamCollab -> Team voice calls (VoIP)

Screenshot 2024-10-13 at 18 53 59

Issue(s)

VOIP-109

Steps to test or reproduce

  • Access the workspace
  • Go to workspace settings
  • Search for the desired setting group
  • Should have updated expressions

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 056117a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 3, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33434/
on branch gh-pages at 2024-10-15 14:19 UTC

@aleksandernsilva aleksandernsilva force-pushed the chore/rename-voip-settings branch from 2b9bd35 to 8d23ef7 Compare October 3, 2024 18:37
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (e476624) to head (056117a).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33434      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.01%     
=================================================
  Files                467      467              
  Lines              20643    20641       -2     
  Branches            5263     5262       -1     
=================================================
- Hits               15442    15439       -3     
  Misses              4590     4590              
- Partials             611      612       +1     
Flag Coverage Δ
unit 74.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva changed the title chore: renamed voip related setting groups chore: renamed voip-related and video conf setting groups Oct 3, 2024
@aleksandernsilva aleksandernsilva changed the title chore: renamed voip-related and video conf setting groups i18n: renamed voip-related and video conf setting groups Oct 4, 2024
@aleksandernsilva aleksandernsilva changed the title i18n: renamed voip-related and video conf setting groups i18n: renamed voip-related and video conf settings Oct 4, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 4, 2024 13:49
@aleksandernsilva aleksandernsilva added this to the 6.14 milestone Oct 4, 2024
@aleksandernsilva aleksandernsilva marked this pull request as draft October 4, 2024 14:44
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 4, 2024 15:19
@aleksandernsilva aleksandernsilva marked this pull request as draft October 7, 2024 13:09
@aleksandernsilva aleksandernsilva force-pushed the chore/rename-voip-settings branch from bccaf79 to 8dec359 Compare October 7, 2024 16:30
@aleksandernsilva aleksandernsilva changed the title i18n: renamed voip-related and video conf settings i18n: renamed voip-related settings Oct 13, 2024
@aleksandernsilva aleksandernsilva force-pushed the chore/rename-voip-settings branch from cd20346 to 8b21926 Compare October 13, 2024 21:52
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 13, 2024 21:55
@aleksandernsilva aleksandernsilva requested review from a team as code owners October 13, 2024 21:55
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be handled as a breaking change -- i.e. tagged as feat!: and heading towards release-7.0.0 branch.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Oct 14, 2024
@aleksandernsilva aleksandernsilva removed the stat: ready to merge PR tested and approved waiting for merge label Oct 14, 2024
@aleksandernsilva aleksandernsilva marked this pull request as draft October 14, 2024 12:52
@aleksandernsilva aleksandernsilva changed the base branch from develop to release-7.0.0 October 14, 2024 12:54
@aleksandernsilva aleksandernsilva changed the title i18n: renamed voip-related settings feat!: renamed voip-related settings Oct 14, 2024
@aleksandernsilva aleksandernsilva force-pushed the chore/rename-voip-settings branch from 3610d02 to 31dfbfc Compare October 14, 2024 13:00
@aleksandernsilva aleksandernsilva force-pushed the chore/rename-voip-settings branch from bc9c7a7 to db01633 Compare October 14, 2024 15:40
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 14, 2024 18:52
@ggazzo ggazzo requested review from a team as code owners October 15, 2024 00:45
@ggazzo ggazzo force-pushed the chore/rename-voip-settings branch from 3a77759 to eb85a79 Compare October 15, 2024 01:00
@tassoevan tassoevan force-pushed the chore/rename-voip-settings branch from eb85a79 to c2af0ff Compare October 15, 2024 04:57
tassoevan
tassoevan previously approved these changes Oct 15, 2024
.changeset/tough-rings-kneel.md Outdated Show resolved Hide resolved
@aleksandernsilva aleksandernsilva merged commit fc807b0 into release-7.0.0 Oct 15, 2024
50 checks passed
@aleksandernsilva aleksandernsilva deleted the chore/rename-voip-settings branch October 15, 2024 16:05
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: renamed voip settings

* i18n: expressions for voip team collab

* chore: renamed omnichannel voip settings group

* i18n: removed and adjusted expression

* chore: changeset

* chore: adjusted migration

* chore: updated changeset to major
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: renamed voip settings

* i18n: expressions for voip team collab

* chore: renamed omnichannel voip settings group

* i18n: removed and adjusted expression

* chore: changeset

* chore: adjusted migration

* chore: updated changeset to major
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: renamed voip settings

* i18n: expressions for voip team collab

* chore: renamed omnichannel voip settings group

* i18n: removed and adjusted expression

* chore: changeset

* chore: adjusted migration

* chore: updated changeset to major
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: renamed voip settings

* i18n: expressions for voip team collab

* chore: renamed omnichannel voip settings group

* i18n: removed and adjusted expression

* chore: changeset

* chore: adjusted migration

* chore: updated changeset to major
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants