Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated endpoint livechat/room.visitor #33461

Merged

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 4, 2024

Proposed changes (including videos or screenshots)

Removed deprecated endpoint livechat/room.visitor.

Issue(s)

Steps to test or reproduce

Further comments

CORE-406

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 4, 2024
@abhinavkrin abhinavkrin requested review from a team as code owners October 4, 2024 13:18
Copy link
Contributor

dionisio-bot bot commented Oct 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 1beb4d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/rest-typings Major
@rocket.chat/meteor Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 16:45 UTC

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@bcdb415). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33461   +/-   ##
================================================
  Coverage                 ?   75.66%           
================================================
  Files                    ?      430           
  Lines                    ?    19904           
  Branches                 ?     5079           
================================================
  Hits                     ?    15060           
  Misses                   ?     4273           
  Partials                 ?      571           
Flag Coverage Δ
unit 75.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Oct 8, 2024
@ggazzo ggazzo dismissed tassoevan’s stale review October 8, 2024 17:42

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 8, 2024 17:42
@tassoevan tassoevan force-pushed the chore/remove-deprecated-endpoint-livechat/room.visitor branch from f0b012a to 0746ba6 Compare October 9, 2024 05:49
tassoevan
tassoevan previously approved these changes Oct 9, 2024
@sampaiodiego sampaiodiego dismissed tassoevan’s stale review October 9, 2024 15:20

The merge-base changed after approval.

@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the chore/remove-deprecated-endpoint-livechat/room.visitor branch from 0746ba6 to 96672ff Compare October 9, 2024 19:55
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 9, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 9, 2024
@ggazzo ggazzo removed the stat: QA assured Means it has been tested and approved by a company insider label Oct 10, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 10, 2024
@MarcosSpessatto MarcosSpessatto removed the request for review from a team October 11, 2024 12:51
@ggazzo ggazzo dismissed MarcosSpessatto’s stale review October 11, 2024 15:56

The merge-base changed after approval.

abhinavkrin and others added 2 commits October 11, 2024 13:41
@ggazzo ggazzo force-pushed the chore/remove-deprecated-endpoint-livechat/room.visitor branch from 96672ff to 1beb4d4 Compare October 11, 2024 16:41
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@ggazzo ggazzo merged commit bb59bc4 into release-7.0.0 Oct 11, 2024
7 of 10 checks passed
@ggazzo ggazzo deleted the chore/remove-deprecated-endpoint-livechat/room.visitor branch October 11, 2024 16:42
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants