Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(i18n): Increase the adoption of react-i18next - Phase 1" #33485

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

It reverts 98b6a20.

Issue(s)

Steps to test or reproduce

Further comments

There is strong evidence that a small change introduced by react-i18next@15.0.0 might have been causing multiple issues.

Copy link
Contributor

dionisio-bot bot commented Oct 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: d34c021

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-08 18:26 UTC

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.58%. Comparing base (d661782) to head (d34c021).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33485      +/-   ##
===========================================
+ Coverage    58.57%   58.58%   +0.01%     
===========================================
  Files         2737     2737              
  Lines        65763    65679      -84     
  Branches     14826    14824       -2     
===========================================
- Hits         38521    38479      -42     
+ Misses       24463    24421      -42     
  Partials      2779     2779              
Flag Coverage Δ
unit 75.66% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review October 7, 2024 21:33
@tassoevan tassoevan requested review from a team as code owners October 7, 2024 21:33
@ggazzo ggazzo merged commit af202c7 into develop Oct 8, 2024
50 checks passed
@ggazzo ggazzo deleted the revert/refactor-i18next branch October 8, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants