Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to matrix-* #33525

Merged
merged 83 commits into from
Oct 18, 2024
Merged

chore: move to matrix-* #33525

merged 83 commits into from
Oct 18, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 10, 2024

https://rocketchat.atlassian.net/browse/ARCH-1287

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: d79bced

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33525/
on branch gh-pages at 2024-10-18 19:24 UTC

@ggazzo ggazzo changed the title chore: move to matrix-sdk-crypto chore: move to matrix-* Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (94a1119) to head (d79bced).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33525      +/-   ##
===========================================
+ Coverage    74.85%   74.88%   +0.02%     
===========================================
  Files          470      473       +3     
  Lines        20744    20810      +66     
  Branches      5295     5314      +19     
===========================================
+ Hits         15528    15583      +55     
- Misses        4595     4602       +7     
- Partials       621      625       +4     
Flag Coverage Δ
unit 74.88% <71.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/matrix=deps branch 2 times, most recently from 8cfcc06 to 2c3c1c2 Compare October 11, 2024 00:26
@debdutdeb debdutdeb self-assigned this Oct 13, 2024
@debdutdeb debdutdeb changed the base branch from develop to release-7.0.0 October 14, 2024 02:36
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
@ggazzo ggazzo force-pushed the chore/matrix=deps branch from 9ccd5d3 to 10fd9da Compare October 15, 2024 15:17
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 08d4324 to 57dd899 Compare October 17, 2024 03:35
Base automatically changed from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
@ggazzo ggazzo added this to the 7.0 milestone Oct 18, 2024
@ggazzo ggazzo marked this pull request as ready for review October 18, 2024 17:33
@ggazzo ggazzo requested review from a team as code owners October 18, 2024 17:33
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By having compiled the bindings for alpine, do we still need to dynamically import the packages? 🤔

KevLehman
KevLehman previously approved these changes Oct 18, 2024
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Marcos' comment, everything else looks fine.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ggazzo
Copy link
Member Author

ggazzo commented Oct 18, 2024

By having compiled the bindings for alpine, do we still need to dynamically import the packages? 🤔

probably not, but there is no need to import if we are not using, also its maintaining the matrix code is not the real objective here, just update the deps and keeping the footprint smaller as we can

@ggazzo ggazzo dismissed MarcosSpessatto’s stale review October 18, 2024 18:58

please create a task ;)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@ggazzo ggazzo merged commit 4692150 into develop Oct 18, 2024
53 checks passed
@ggazzo ggazzo deleted the chore/matrix=deps branch October 18, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: needs testing stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants