-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move to matrix-*
#33525
chore: move to matrix-*
#33525
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33525 +/- ##
===========================================
+ Coverage 74.85% 74.88% +0.02%
===========================================
Files 470 473 +3
Lines 20744 20810 +66
Branches 5295 5314 +19
===========================================
+ Hits 15528 15583 +55
- Misses 4595 4602 +7
- Partials 621 625 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
8cfcc06
to
2c3c1c2
Compare
375c521
to
63e06da
Compare
bfefe41
to
204272c
Compare
42e5775
to
e025fad
Compare
9ccd5d3
to
10fd9da
Compare
08d4324
to
57dd899
Compare
7ec9a71
to
62d5073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By having compiled the bindings for alpine, do we still need to dynamically import the packages? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from Marcos' comment, everything else looks fine.
probably not, but there is no need to import if we are not using, also its maintaining the matrix code is not the real objective here, just update the deps and keeping the footprint smaller as we can |
https://rocketchat.atlassian.net/browse/ARCH-1287
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments