Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated livechat:setDepartmentForVisitor method #33526

Merged

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 10, 2024

Proposed changes (including videos or screenshots)

Removes deprecated method livechat:setDepartmentForVisitor. Moving forward, use the endpoint livechat/visitor.

Issue(s)

Steps to test or reproduce

Further comments

CORE-378

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 10, 2024
@abhinavkrin abhinavkrin requested a review from a team as a code owner October 10, 2024 18:40
Copy link
Contributor

dionisio-bot bot commented Oct 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: e1ace3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 16:39 UTC

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@479445b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33526   +/-   ##
================================================
  Coverage                 ?   75.70%           
================================================
  Files                    ?      432           
  Lines                    ?    19919           
  Branches                 ?     5084           
================================================
  Hits                     ?    15079           
  Misses                   ?     4269           
  Partials                 ?      571           
Flag Coverage Δ
unit 75.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo dismissed MarcosSpessatto’s stale review October 11, 2024 15:56

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 11, 2024 15:56
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@ggazzo ggazzo force-pushed the chore/remove-deprecated-setDepartmentForVisitor branch from e1ace3d to 47ae23c Compare October 11, 2024 16:38
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 11, 2024
@ggazzo ggazzo merged commit 2b332e3 into release-7.0.0 Oct 11, 2024
8 of 10 checks passed
@ggazzo ggazzo deleted the chore/remove-deprecated-setDepartmentForVisitor branch October 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants