Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send message to admins when app is disabled due to add-on #33534

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Oct 11, 2024

Proposed changes (including videos or screenshots)

Send a message when an app is disabled automatically because an add-on (external module) became invalid.

Issue(s)

ADD-13

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 8f881d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert changed the base branch from develop to feat/license-addons October 11, 2024 01:25
Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33534/
on branch gh-pages at 2024-10-17 13:58 UTC

@d-gubert d-gubert added this to the 6.14 milestone Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.54%. Comparing base (fbfc1a7) to head (8f881d5).
Report is 1 commits behind head on feat/license-addons.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat/license-addons   #33534   +/-   ##
====================================================
  Coverage                58.54%   58.54%           
====================================================
  Files                     2779     2779           
  Lines                    66477    66487   +10     
  Branches                 15026    15028    +2     
====================================================
+ Hits                     38920    38927    +7     
- Misses                   24732    24735    +3     
  Partials                  2825     2825           
Flag Coverage Δ
unit 74.85% <73.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review October 11, 2024 16:56
@d-gubert d-gubert requested a review from a team as a code owner October 11, 2024 16:56
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we use the same changeset for the parent PR, right?

@d-gubert
Copy link
Member Author

Will we use the same changeset for the parent PR, right?

I think it makes sense for us to do so, yes

@d-gubert d-gubert force-pushed the feat/bot-message-on-invalid-addon branch from 85b49ce to 8f881d5 Compare October 17, 2024 13:39
@d-gubert d-gubert modified the milestones: 6.14, 7.0 Oct 17, 2024
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Oct 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
@d-gubert d-gubert merged commit de510c2 into feat/license-addons Oct 17, 2024
49 of 52 checks passed
@d-gubert d-gubert deleted the feat/bot-message-on-invalid-addon branch October 17, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants