-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send message to admins when app is disabled due to add-on #33534
feat: send message to admins when app is disabled due to add-on #33534
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/license-addons #33534 +/- ##
====================================================
Coverage 58.54% 58.54%
====================================================
Files 2779 2779
Lines 66477 66487 +10
Branches 15026 15028 +2
====================================================
+ Hits 38920 38927 +7
- Misses 24732 24735 +3
Partials 2825 2825
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we use the same changeset for the parent PR, right?
apps/meteor/tests/unit/app/lib/server/apps/disableAppsWithAddonsCallback.spec.ts
Show resolved
Hide resolved
I think it makes sense for us to do so, yes |
85b49ce
to
8f881d5
Compare
Proposed changes (including videos or screenshots)
Send a message when an app is disabled automatically because an add-on (external module) became invalid.
Issue(s)
ADD-13
Steps to test or reproduce
Further comments