Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: E2EE room's Key icon no longer toggles encryption of room #33572

Merged
merged 9 commits into from
Oct 15, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Oct 14, 2024

Proposed changes (including videos or screenshots)

This is a behavior change of the room header. Previously, room's encryption status could be disabled by clicking on the Key icon of the room header, given the user had permission. Now, the only way to toggle encryption of a room will be through the ellipsis menu.
Button is no longer clickable and just serves as a visual cue that room is encrypted or not.

Issue(s)

https://rocketchat.atlassian.net/browse/E2EE2-77

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 88e3232

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman added this to the 7.0 milestone Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33572/
on branch gh-pages at 2024-10-15 18:35 UTC

@KevLehman KevLehman force-pushed the feat/remove-key-icon-click-behavior branch from f472f1f to 74e77b1 Compare October 14, 2024 21:40
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (e476624) to head (88e3232).
Report is 8 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33572      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.01%     
=================================================
  Files                467      467              
  Lines              20643    20641       -2     
  Branches            5263     5262       -1     
=================================================
- Hits               15442    15439       -3     
  Misses              4590     4590              
- Partials             611      612       +1     
Flag Coverage Δ
unit 74.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the feat/remove-key-icon-click-behavior branch from 3a1dc35 to 6cc9321 Compare October 15, 2024 05:51
@KevLehman KevLehman marked this pull request as ready for review October 15, 2024 15:56
@KevLehman KevLehman requested a review from a team as a code owner October 15, 2024 15:56
KevLehman and others added 2 commits October 15, 2024 11:57
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2024
@KevLehman KevLehman merged commit 6d0e099 into release-7.0.0 Oct 15, 2024
50 of 52 checks passed
@KevLehman KevLehman deleted the feat/remove-key-icon-click-behavior branch October 15, 2024 20:00
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…33572)

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…33572)

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…33572)

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
…33572)

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants