-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: E2EE room's Key
icon no longer toggles encryption of room
#33572
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 88e3232 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
f472f1f
to
74e77b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33572 +/- ##
=================================================
- Coverage 74.80% 74.79% -0.01%
=================================================
Files 467 467
Lines 20643 20641 -2
Branches 5263 5262 -1
=================================================
- Hits 15442 15439 -3
Misses 4590 4590
- Partials 611 612 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
3a1dc35
to
6cc9321
Compare
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changeset
…33572) Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
…33572) Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
…33572) Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
…33572) Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Proposed changes (including videos or screenshots)
This is a behavior change of the room header. Previously, room's encryption status could be disabled by clicking on the
Key
icon of the room header, given the user had permission. Now, the only way to toggle encryption of a room will be through the ellipsis menu.Button is no longer clickable and just serves as a visual cue that room is encrypted or not.
Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-77
Steps to test or reproduce
Further comments