Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove decryption step from E2EE and leave it only on room's ready event #33587

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: e78e3d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33587/
on branch gh-pages at 2024-10-15 16:39 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (1f5e0fd) to head (e78e3d2).
Report is 2 commits behind head on feat/e2e-key-reset-modal.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           feat/e2e-key-reset-modal   #33587   +/-   ##
=========================================================
  Coverage                     74.79%   74.79%           
=========================================================
  Files                           467      467           
  Lines                         20641    20641           
  Branches                       5262     5262           
=========================================================
  Hits                          15439    15439           
  Misses                         4590     4590           
  Partials                        612      612           
Flag Coverage Δ
unit 74.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review October 15, 2024 17:32
@KevLehman KevLehman merged commit 860f27f into feat/e2e-key-reset-modal Oct 15, 2024
47 of 50 checks passed
@KevLehman KevLehman deleted the fix/double-decrypt-when-allowing-unenc-content branch October 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant