Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collapse sidebar groups #33592

Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat: collapse sidebar groups #33592

merged 7 commits into from
Oct 18, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 15, 2024

SIDE-178

Proposed changes (including videos or screenshots)

  • add collapsible groups to sidebar
  • save to localStorage collapsed groups - keeps state after reload
    Kapture 2024-10-18 at 12 12 11

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 7f9025c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-theming Minor
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Minor
@rocket.chat/ui-composer Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/meteor Minor
@rocket.chat/livechat Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti changed the base branch from develop to release-7.0.0 October 15, 2024 18:37
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33592/
on branch gh-pages at 2024-10-18 19:11 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.89%. Comparing base (94a1119) to head (7f9025c).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33592      +/-   ##
===========================================
+ Coverage    74.85%   74.89%   +0.03%     
===========================================
  Files          470      473       +3     
  Lines        20744    20807      +63     
  Branches      5295     5311      +16     
===========================================
+ Hits         15528    15583      +55     
- Misses        4595     4599       +4     
- Partials       621      625       +4     
Flag Coverage Δ
unit 74.89% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti added this to the 7.0 milestone Oct 16, 2024
@juliajforesti juliajforesti force-pushed the feat/sidebar-collapser branch from 0432225 to 3e06587 Compare October 16, 2024 21:46
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 08d4324 to 57dd899 Compare October 17, 2024 03:35
Base automatically changed from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
An error occurred while trying to automatically change base from release-7.0.0 to develop October 17, 2024 04:28
@juliajforesti juliajforesti force-pushed the feat/sidebar-collapser branch from 3e06587 to 355da70 Compare October 17, 2024 21:57
@juliajforesti juliajforesti marked this pull request as ready for review October 17, 2024 23:14
@juliajforesti juliajforesti requested a review from a team as a code owner October 17, 2024 23:14
@juliajforesti juliajforesti force-pushed the feat/sidebar-collapser branch from ebcfd25 to 62d3bfa Compare October 18, 2024 15:10
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@ggazzo ggazzo merged commit 9274cf4 into develop Oct 18, 2024
54 of 77 checks passed
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants