Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setting to map an ldap attribute to the user's voice extension #33598

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 15, 2024

Proposed changes (including videos or screenshots)

Issue(s)

VOIP-36

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.14 milestone Oct 15, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: dbdbc20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/core-typings Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 15, 2024 22:55
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 15, 2024 22:55
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33598/
on branch gh-pages at 2024-10-16 16:27 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.42%. Comparing base (5cc9ac5) to head (dbdbc20).
Report is 142 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33598   +/-   ##
========================================
  Coverage    58.42%   58.42%           
========================================
  Files         2745     2746    +1     
  Lines        66275    66286   +11     
  Branches     14998    15002    +4     
========================================
+ Hits         38723    38730    +7     
- Misses       24730    24732    +2     
- Partials      2822     2824    +2     
Flag Coverage Δ
unit 74.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

.changeset/shiny-falcons-vanish.md Outdated Show resolved Hide resolved
apps/meteor/server/lib/ldap/Manager.ts Outdated Show resolved Hide resolved
apps/meteor/server/settings/ldap.ts Show resolved Hide resolved
pierre-lehnen-rc and others added 2 commits October 16, 2024 13:02
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@ggazzo ggazzo merged commit e3629e0 into develop Oct 18, 2024
50 checks passed
@ggazzo ggazzo deleted the feat/voip-ldap branch October 18, 2024 02:38
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants