feat!: shrink payload of the startImport endpoint #33630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f06cfb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33630 +/- ##
===========================================
+ Coverage 74.81% 74.85% +0.04%
===========================================
Files 469 470 +1
Lines 20687 20743 +56
Branches 5278 5294 +16
===========================================
+ Hits 15477 15528 +51
Misses 4595 4595
- Partials 615 620 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
pierre-lehnen-rc
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
MarcosSpessatto
approved these changes
Oct 18, 2024
aleksandernsilva
approved these changes
Oct 18, 2024
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The startImport endpoint requires a list of users and channels that should be imported. Back when it was first implemented, this list was configured to use the same type as another list that is already being used elsewhere in the import process (an instance of the ImporterSelection class), but that class includes a lot of extra information that is not strictly required for this endpoint, such as the name and email of every user and name and creator of every channel. This caused the payload of this endpoint to get very large when importing a huge amount of records.
This PR changes the signature of the endpoint to simply receive a list of user ids and channel ids, or, when none of the users/channels were unchecked, a simple "all: true" flag.
Issue(s)
CONN-366
Steps to test or reproduce
Further comments