Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove query field on online groups listing #33647

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

ricardogarim
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: c6bc517

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33647/
on branch gh-pages at 2024-10-18 17:34 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (d879c8b) to head (2750e29).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33647   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20744    20744           
  Branches      5295     5295           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       621      621           
Flag Coverage Δ
unit 74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim added this to the 7.0 milestone Oct 18, 2024
@MarcosSpessatto MarcosSpessatto changed the title chore: remove query field on online groups listing chore!: remove query field on online groups listing Oct 18, 2024
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 18, 2024 18:44
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners October 18, 2024 18:44
@MarcosSpessatto MarcosSpessatto added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 18, 2024
@ggazzo ggazzo merged commit 15582b1 into develop Oct 18, 2024
6 of 7 checks passed
@ggazzo ggazzo deleted the chore/groups-online-query-param branch October 18, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants