-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: remove query field on messages listing #33801
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 09bb8bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33801 +/- ##
==============================================
Coverage 74.96% 74.96%
==============================================
Files 481 481
Lines 21044 21044
Branches 5339 5339
==============================================
Hits 15776 15776
Misses 4636 4636
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
49fef9f
to
09bb8bb
Compare
Proposed changes (including videos or screenshots)
Per CORE-767, this update shifts the
mentions._id
,starred._id
, andpinned
query parameters directly to the root level in GET/api/v1/channels.messages
and removes the query attribute.mentions._id
should now be passed asmentionIds
directly at the root level and supports a comma-separated list of setting IDs (e.g.,mentionIds=foo
ormentionIds=foo,bar
).starred._id
should now be passed asstarredIds
directly at the root level and supports a comma-separated list of setting IDs (e.g.,starredIds=foo
orstarredIds=foo,bar
).pinned
should now be passed directly at the root level as a boolean or string.ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS
environment variable totrue
when initializing the server.Issue(s)
Steps to test or reproduce
Further comments
Note to Mobile Team – Based on channels.ts#L112, it looks like
mentions._id
,starred._id
, andpinned
are the attributes needing support. If any other parameters are required, please reach out.