Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stop injecting settings' getter on FreeSwitch service #34201

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Taken from #34004

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 7d2fbcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34201/
on branch gh-pages at 2024-12-17 15:55 UTC

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.83%. Comparing base (7edc3db) to head (7d2fbcc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34201   +/-   ##
========================================
  Coverage    75.83%   75.83%           
========================================
  Files          511      511           
  Lines        22171    22172    +1     
  Branches      5397     5397           
========================================
+ Hits         16813    16814    +1     
  Misses        4710     4710           
  Partials       648      648           
Flag Coverage Δ
unit 75.83% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review December 17, 2024 16:31
@KevLehman KevLehman requested a review from a team as a code owner December 17, 2024 16:31
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Dec 17, 2024
@KevLehman KevLehman added this to the 7.2.0 milestone Dec 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 17, 2024
@kodiakhq kodiakhq bot merged commit 0fcdc3e into develop Dec 17, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/stop-inject branch December 17, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants