Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: JSX automatic runtime #34498

Merged
merged 4 commits into from
Dec 26, 2024
Merged

refactor: JSX automatic runtime #34498

merged 4 commits into from
Dec 26, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 24, 2024

Proposed changes (including videos or screenshots)

It removes the deprecated default import of react.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: ba65467

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 24, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34498/
on branch gh-pages at 2024-12-24 16:09 UTC

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (86a21b5) to head (ba65467).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34498      +/-   ##
===========================================
- Coverage    59.27%   59.27%   -0.01%     
===========================================
  Files         2820     2820              
  Lines        67843    67833      -10     
  Branches     15075    15074       -1     
===========================================
- Hits         40216    40208       -8     
+ Misses       24810    24808       -2     
  Partials      2817     2817              
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/react-jsx-runtime branch from 0a4783e to b47e77f Compare December 24, 2024 15:07
@tassoevan tassoevan added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 24, 2024
@tassoevan tassoevan force-pushed the refactor/react-jsx-runtime branch from b5333fd to 6dd858e Compare December 24, 2024 18:37
@tassoevan tassoevan force-pushed the refactor/react-jsx-runtime branch from 6dd858e to ba65467 Compare December 24, 2024 23:22
@tassoevan tassoevan added this to the 7.3.0 milestone Dec 24, 2024
@tassoevan tassoevan marked this pull request as ready for review December 24, 2024 23:57
@tassoevan tassoevan requested review from a team as code owners December 24, 2024 23:57
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggazzo ggazzo merged commit 9af2c11 into develop Dec 26, 2024
50 checks passed
@ggazzo ggazzo deleted the refactor/react-jsx-runtime branch December 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants