Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Missing page "not found" #6673

Merged
merged 13 commits into from
Apr 17, 2018
Merged

Conversation

Prakharsvnit
Copy link

fixes #6366

@RocketChat/core

Improvements required: enlarge font-size and change font-color

@sampaiodiego
Copy link
Member

hey, thanks for your contribution. can you please fix the lint/codacy errors?

also, you should translate the messages on template like this and adding it source like this

@sampaiodiego
Copy link
Member

@Prakharsvnit you're still not using the translated text on template. please change this:
<h1>Error:404</h1>
by this:
<h1>{{_ "Error_404"}}</h1>

and so on.
thx

@Prakharsvnit
Copy link
Author

@sampaiodiego Tested changes on my local machine, it gives output as

Sorry_page_you_requested_does_not_exists_or_was_deleted

which shouldn't be the case.

@pkgodara
Copy link
Contributor

pkgodara commented Jun 2, 2017

@Prakharsvnit I had same problem. The problem seems due to cache. You will have to clear cache & rebuild your app.

There are two ways around.

  1. Meteor reset meteor reset but it will also delete your database (I would not recommend personally).

  2. I tried meteor rebuild but it would not help since it does not rebuild whole app. So you will have to manually delete all these folders in .meteor/local :
    build bundler-cache isopacks plugin-cache shell

Now run it again meteor npm start. Works for me.

Copy link
Contributor

@pkgodara pkgodara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice if there is 'Home' page link in Error page.

@geekgonecrazy
Copy link
Contributor

@Prakharsvnit sorry for the delay on this one. I like the suggestion of linking to the home page. That way the user isn't stuck once they get this page.

Is that something you could add?

@geekgonecrazy
Copy link
Contributor

@karlprieb what do you think? It'd probably be great to have a nice page at some point with designer being involved. But this would be better than what we have now

@geekgonecrazy geekgonecrazy changed the title added error page [FIX] Missing page not found Mar 29, 2018
@karlprieb
Copy link
Contributor

@geekgonecrazy maybe we should accept this until we have our own "page not found" design.

@arthurgiustina is it hard to create a "page not found" page design?

@karlprieb karlprieb added this to the 0.64.0 milestone Apr 3, 2018
@karlprieb karlprieb added the ui/ux label Apr 4, 2018
@rodrigok rodrigok changed the title [FIX] Missing page not found [FIX] Missing page "not found" Apr 17, 2018
@rodrigok rodrigok merged commit 3115ec6 into RocketChat:develop Apr 17, 2018
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error page when connecting to wrong url https://[server_name]/[wrong_name]
6 participants