-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Integrated personal email gateway (GSoC'17) #7342
Conversation
local update
function getEmails(imap) { | ||
imap.search(['UNSEEN'], function(err, newEmails) { | ||
if (err) { | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you return after the console.log? If error exists newEmails
will be empty probably and the next if will throw an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its there until I'm testing it, so that its easier for me to test/debug, would remove it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should throw an error here.
Nice! Are attachments supported? |
@localguru Thanks. As par now only text is supported. I'm planning to support attachments in near future after it is successfully tested. |
@@ -1133,6 +1133,8 @@ | |||
"Offline_form": "Offline formulář", | |||
"Offline_form_unavailable_message": "Zpráva nedostupného offline formuláře", | |||
"Offline_Link_Message": "PŘEJÍT NA ZPRÁVU", | |||
"Offline_Mention_Email": "Zmínka od __user__ v #__room__", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to remove these two lines. Offline_Mention_Email
& Offline_Mention_All_Email
. These has been changed to https://github.com/RocketChat/Rocket.Chat/pull/7342/files#diff-900a71156bf66b90776f869f3f63ccd9R1191 as subjects are moved to settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do it later sometime.
@pkgodara hi, how difficult would it be to bypass the requirement of direct mail server access and make a command line tool available? Then it also does not need to poll. I take this idea from RequestTracker, basically a small script/command that translates email on stdin to a webhook: https://docs.bestpractical.com/rt/4.4.0/rt-mailgate.html#SETUP |
}); | ||
}); | ||
|
||
imap.once('error', function(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imap.once('error', function(err) {
console.log(err);
});
can it be that it should be
imap.once('error', function(err) {
console.log(err);
imap.connect(); ???
});
PR for project under Google Summer of Code, 2017.
Enable direct email reply. For more features, see below.
Features Implemented:
Enable replies over IMAP protocol (Replying to an email from rocket.chat and have it posts message to the channel #6129)
Enable replies over POP3 protocol (Replying to an email from rocket.chat and have it posts message to the channel #6129)
Idea: The basic idea is to sub-address
Reply-To
email such that message information can be gathered.If email address is
local@domain
then the addresslocal+tag@domain
denotes same delivery addresslocal@domain
but contains extratag
(We used it).tag
throughout email replies & is supported by several email services including Runbox (plus), Gmail (plus), Yahoo! Mail Plus (hyphen), Apple's iCloud (plus), Outlook.com (plus), FastMail (plus and Subdomain Addressing), MMDF (equals), Qmail and Courier Mail Server (hyphen). As I observed, many companies including Github itself utilises this method to enable direct replies.All messages sent by email would contain an icon (displayed in below image) along-side message action button.
Here Integrated personal email gateway (GSoC'17) docs-old#366 .
Not done in this PR
Closes #6129, #6118, #7601
Not sure about #4384, #4078