[NEW] Search users by fields defined by admin #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes introduce the possibility of searching users by any field the Rocket.Chat's administrator defines in the new "Accounts -> Fields to consider in search" field.
rodrigok
reviewed
Aug 23, 2017
| name: termRegex | ||
| }, | ||
| { | ||
| 'emails.address': termRegex |
There was a problem hiding this comment.
What happened with this field on search?
There was a problem hiding this comment.
It must be added as default in the settings.js. Will fix it.
There was a problem hiding this comment.
@rodrigok I've made a new commit which I think has a better implementation and fix the issue you commented above.
- Undone the changes to spotlight.js: The fields returned are only name, email and status as before (since we do not use other fields, there is no reason to return them, at least by now) - Retrieving from mongo the fields to search by in the Users.js model (instead of using the fields coming from spotlight.js) - Fixed the emails.address field that was removed by mistake in the prior commit
goiaba
commented
Aug 23, 2017
| name: termRegex | ||
| }, | ||
| { | ||
| 'emails.address': termRegex |
There was a problem hiding this comment.
@rodrigok I've made a new commit which I think has a better implementation and fix the issue you commented above.
rodrigok
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce the possibility of searching users by any field the Rocket.Chat's administrator defines in the new "Accounts -> Fields to consider in search" field.
@RocketChat/core
Related to #7334 and #7210.
Example: