-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] scroll on flex-tab #7748
[FIX] scroll on flex-tab #7748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that you broke a test
{{#unless hasMessages}} | ||
<h2>{{_ "No_mentions_found"}}</h2> | ||
{{/unless}} | ||
{{#unless hasMessages}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not introduce unnecessary changes
{{#unless searchResultMessages}} | ||
<h2>{{_ "No_results_found"}}</h2> | ||
{{/unless}} | ||
{{#unless searchResultMessages}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not introduce unnecessary changes
@@ -93,7 +93,8 @@ Template.messageSearch.events({ | |||
return t.search(); | |||
}, | |||
|
|||
'scroll .content': _.throttle(function(e, t) { | |||
'scroll .js-list': _.throttle(function(e, t) { | |||
console.log('tete'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this log
@RocketChat/core
Closes #7695