Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] scroll on flex-tab #7748

Merged
merged 5 commits into from
Aug 21, 2017
Merged

[FIX] scroll on flex-tab #7748

merged 5 commits into from
Aug 21, 2017

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 15, 2017

@RocketChat/core

Closes #7695

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7748 August 15, 2017 15:08 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that you broke a test

{{#unless hasMessages}}
<h2>{{_ "No_mentions_found"}}</h2>
{{/unless}}
{{#unless hasMessages}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not introduce unnecessary changes

{{#unless searchResultMessages}}
<h2>{{_ "No_results_found"}}</h2>
{{/unless}}
{{#unless searchResultMessages}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not introduce unnecessary changes

@@ -93,7 +93,8 @@ Template.messageSearch.events({
return t.search();
},

'scroll .content': _.throttle(function(e, t) {
'scroll .js-list': _.throttle(function(e, t) {
console.log('tete');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this log

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-7748 August 21, 2017 21:23 Inactive
@rodrigok rodrigok added this to the 0.59.0 milestone Aug 21, 2017
@rodrigok rodrigok merged commit a58616a into develop Aug 21, 2017
@rodrigok rodrigok deleted the scroll-flex-tab branch August 21, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load more in flex tabs not working
4 participants