Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Create a standard for our svg icons #7853

Merged
merged 6 commits into from
Aug 24, 2017
Merged

[NEW] Create a standard for our svg icons #7853

merged 6 commits into from
Aug 24, 2017

Conversation

karlprieb
Copy link
Contributor

@karlprieb karlprieb commented Aug 23, 2017 •
edited
Loading

@RocketChat/core

Now all our svg icons will have 20x20 viewbox

@karlprieb karlprieb requested review from rodrigok and ggazzo August 23, 2017 17:49
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7853 August 23, 2017 17:49 Inactive
@sampaiodiego
Copy link
Member

Looks like the <svg /> sprite is visible:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7853 August 23, 2017 20:21 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7853 August 23, 2017 20:27 Inactive
@sampaiodiego
Copy link
Member

the autogrow shadow is there as well
image

@karlprieb
Copy link
Contributor Author

@sampaiodiego Already fixed that white bar :)
Can you open an issue about that autogrow shadow? It's not related to this PR.

@rodrigok rodrigok merged commit e7bb0f5 into develop Aug 24, 2017
@rodrigok rodrigok deleted the fix-svg-sprite branch August 24, 2017 20:44
This was referenced Oct 20, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlprieb @sampaiodiego @rodrigok @engelgabriel