[FIX] Double scroll on 'keyboard shortcuts' menu in sidepanel #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
changed the title
MartinSchoeler
previously requested changes
Aug 28, 2017
| @@ -1,5 +1,5 @@ | |||
| <template name="keyboardShortcuts"> | |||
| <div class="content"> | |||
| <!-- <div class="content"> --> | |||
There was a problem hiding this comment.
Please remove the tag instead of commenting
There was a problem hiding this comment.
Sure, will do the same.
…nto sidepane-scrollbar-fix
karlprieb
approved these changes
Aug 29, 2017
rodrigok
added a commit
that referenced
this pull request
Aug 30, 2017
[FIX] Double scroll on 'keyboard shortcuts' menu in sidepanel
|
@aditya19496 @rodrigok @karlprieb Not sure this is actually fixed. In 0.59.x it looks like this with the double scroll But now in 60.2 it looks like this: |
|
@karlprieb @rodrigok I also confirmed that it's break in version 60 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7901