-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] User avatars from external source #7929
Merged
sampaiodiego
merged 20 commits into
RocketChat:develop
from
mjovanovic0:7743-feature-user-avatar-from-external-source
Feb 8, 2019
Merged
[NEW] User avatars from external source #7929
sampaiodiego
merged 20 commits into
RocketChat:develop
from
mjovanovic0:7743-feature-user-avatar-from-external-source
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sampaiodiego can you take a look at this one? |
…urce # Conflicts: # packages/rocketchat-ui/getAvatarUrlFromUsername.js
I updated MR to latest develop |
sampaiodiego
approved these changes
Feb 8, 2019
This was referenced Feb 8, 2019
Montel
pushed a commit
to Montel/Rocket.Chat
that referenced
this pull request
Feb 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7743
In settings I added new property:
Accounts_AvatarExternalProviderUrl
which holds information of external avatar provider url template (ex.:https://acme.com/api/v1/{username}
.External avatar provider url is resolved with user
username
for every avatar reference in application.