Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Sender's name in email notifications. #7999

Merged
merged 3 commits into from
Dec 8, 2017

Conversation

pkgodara
Copy link
Contributor

@pkgodara pkgodara commented Aug 31, 2017

In case Channel, Channel name would appear in place of sender's name.

In case DM, If sender's name is John Doe then, in email notifications, it would appear as if John Doe has sent the email.

Initially emails looked like:
screenshot from 2017-08-30 13-33-13

Now emails would be more specific:
screenshot from 2017-09-06 12-40-50

@RocketChat/core

@rodrigok rodrigok added this to the 0.60.0 milestone Sep 5, 2017
@geekgonecrazy
Copy link
Contributor

In a DM I think this would make total sense. But in a channel... I think this should maybe should something to indicate channel name.

I say this because if it says it comes from John if reply by email feature is enabled and they replied... You aren't really replying just to John. We need to not confuse users

@sampaiodiego
Copy link
Member

I agree with @geekgonecrazy .. also on Gmail on subsequent replies to that channel it will group as if "John Doe" replies even if they are not..

@pkgodara
Copy link
Contributor Author

pkgodara commented Sep 6, 2017

@geekgonecrazy @sampaiodiego I've updated accordingly. Can you check it again?

@sampaiodiego
Copy link
Member

looks good

@rodrigok rodrigok merged commit 88177c5 into RocketChat:develop Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants