[FIX] Some RTL fix (#7992 and #7821) #8063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyclops24 Can you rename your PR? Use something more specific ;) @ggazzo is fixing some RTL bugs, can you talk to him about that on demo.rocket.chat? Thanks for you contribution ;) |
cyclops24
changed the title
|
@karlprieb What approach you suggest rather than top padding on user avatar? |
|
duplicated solution here #8112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7992 and #7821
This is a start point to fix #7821 :
And fix #7992 related to closed PR #8024
I can continue work on it if it's OK until here. 😉
/CC: @karlprieb , @ggazzo