Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add "real name change" setting #8739

Merged

Conversation

AmShaegar13
Copy link
Contributor

@AmShaegar13 AmShaegar13 commented Oct 31, 2017

@RocketChat/core

Closes #8576

Added a setting to allow real name updates. This was necessary after avatar updating was merged into profile page. One could not allow avatar updates while forbidding name changes (implicitly with fobidding profile updates at all). I used the exact same logic as the username setting does.

Just one question: How about the languages I do not speak? Do I just omit them or fill i18n JSONs with placeholders?

admin_setting
user_profile
bypass_ui

@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch from c4981c7 to faf3a3b Compare October 31, 2017 19:14
@cyclops24
Copy link
Contributor

@AmShaegar13 Thanks for this PR. Usually guys fill English and omit other languages for translators.

@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch from faf3a3b to 4f21890 Compare November 2, 2017 10:20
@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch from 4f21890 to c99fe59 Compare November 6, 2017 09:04
@RocketChat RocketChat deleted a comment Nov 7, 2017
@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch from fba683a to 323fad9 Compare November 7, 2017 12:24
@AmShaegar13
Copy link
Contributor Author

I added some tests to ensure it's working as intended. Should be ready to merge after checks are green.

@AmShaegar13 AmShaegar13 changed the title [WIP][NEW] added real name change setting [NEW] added real name change setting Nov 7, 2017
@gdelavald
Copy link
Contributor

Thanks for your PR, we'll review it and provide feedback when possible.

@AmShaegar13
Copy link
Contributor Author

My new tests are failing. I am still searching for a clever way to make them pass reliably.

@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch 2 times, most recently from ae4c273 to 46baaea Compare November 24, 2017 16:06
@AmShaegar13 AmShaegar13 force-pushed the add_allow_update_real_name_setting branch from 46baaea to 16a4fd4 Compare November 24, 2017 17:08
@AmShaegar13
Copy link
Contributor Author

Okay, tests are green. I am done. :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8739 December 7, 2017 19:01 Inactive
@rodrigok rodrigok added this to the 0.60.0 milestone Dec 7, 2017
@ggazzo
Copy link
Member

ggazzo commented Dec 7, 2017

@AmShaegar13 approved ;)

@rodrigok rodrigok changed the title [NEW] added real name change setting [NEW] Added "real name change" setting Dec 7, 2017
@rodrigok rodrigok changed the title [NEW] Added "real name change" setting [NEW] Add "real name change" setting Dec 7, 2017
@rodrigok rodrigok merged commit a62d710 into RocketChat:develop Dec 7, 2017
@dajoker
Copy link

dajoker commented Sep 14, 2018

I see this is still open; has it been merged at all, or could it be? If working, it s something our users would like. In our case we have disabled Profile changes, but would like Avatar changes still, so that may not be part of what was originally scoped here.

@AmShaegar13 AmShaegar13 deleted the add_allow_update_real_name_setting branch September 17, 2018 06:21
@AmShaegar13
Copy link
Contributor Author

@dajoker This PR was merged and is not open anymore. You can use it from Administration -> Account -> Allow Name Change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Avatar while Profile Change is prohibited
7 participants