Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Change wording to start DM from info panel #8799

Merged
merged 1 commit into from
Apr 15, 2020
Merged

[FIX] Change wording to start DM from info panel #8799

merged 1 commit into from
Apr 15, 2020

Conversation

bryandesrosiers
Copy link
Contributor

Minor word change from "Conversation" to "Direct Message". To keep UI consistency with the left side bar.

@RocketChat/core

Closes #ISSUE_NUMBER

@HammyHavoc
Copy link
Contributor

Nice catch! This was a little difficult figuring out initially; ended up using group channels to begin with until I discovered this.

@geekgonecrazy
Copy link
Contributor

I would tend to agree. @RocketChat/core I know this is part of our new redesign also.

Opening a Conversation doesn't hold consistent with us calling them Direct Messages in channel list.

Should we change it to Direct Message ? I personally think its clearer

HammyHavoc
HammyHavoc previously approved these changes Nov 7, 2017
View reviewed changes
@sampaiodiego
Copy link
Member

I agree. But the new UI is already touching this area, so I would say to opening a PR against the new branch..

Also, there is no translation for "Direct Message", so that will be needed as well..

sampaiodiego
sampaiodiego requested changes Nov 7, 2017
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no translation for "Direct Message", can you please add it as well?

also, can you please target your changes to contextual-bar-redesign branch?

@geekgonecrazy
Copy link
Contributor

@bryandesrosiers @HammyHavoc what do you guys think in context of new UI?

image

@geekgonecrazy geekgonecrazy changed the title Update userInfo.html Change wording to start DM from info panel Feb 16, 2018
@HammyHavoc
Copy link
Contributor

"Conversation" isn't a verb, "Video Call" is; with that in mind, "Direct Message" makes far more sense. :- ) Looking good though lads, really pretty UX! 👍

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Feb 16, 2018 •
edited
Loading

Hm.. maybe "Start Conversation" ?

@karlprieb @arthurgiustina This is a design thing. Thoughts? :)

@HammyHavoc
Copy link
Contributor

I could get behind that idea if we're also going to change 'Direct Messages' elsewhere to 'Conversations'. :- ) Loving the direction things are going; consistency!

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel added this to the 3.2.0 milestone Apr 15, 2020
@ggazzo ggazzo changed the title Change wording to start DM from info panel [FIX] Change wording to start DM from info panel Apr 15, 2020
@ggazzo ggazzo merged commit d788e76 into RocketChat:develop Apr 15, 2020
gabriellsh added a commit that referenced this pull request Apr 15, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into adm/…
8739a89 
…mailer

* 'develop' of github.com:RocketChat/Rocket.Chat: (93 commits)
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  [FIX] Directory users email sort button (#16606)
  [FIX] In Create a New Channel, input should be focused on channel name instead of invite users (#16405)
  [FIX] Email not verified message (#16236)
  [FIX] Directory default tab (#17283)
  Update ru.i18n.json (#16869)
  ...
gabriellsh added a commit that referenced this pull request Apr 15, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into adm/…
e792cba 
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] "Invalid Invite" message when registration is disabled (#17226)
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
ggazzo added a commit that referenced this pull request Apr 15, 2020
@ggazzo
Merge branch 'adm/mailer' of github.com:RocketChat/Rocket.Chat into a…
8ba9fb0 
…dm/mailer

* 'adm/mailer' of github.com:RocketChat/Rocket.Chat: (79 commits)
  removed unecessary prop
  Fixed sendMail function
  Removed Log, Success message
  Permissions
  added route component
  [FIX] "Invalid Invite" message when registration is disabled (#17226)
  Added route, error handling.
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  ...
dudizilla added a commit that referenced this pull request Apr 21, 2020
@dudizilla
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
960d7dd 
…nto view-logs

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (31 commits)
  Fixed componentes width (#17322)
  [IMPROVE] Administration -> Mailer Rewrite to React. (#17191)
  Regression: Storybook  added flowrouter group mock (#17321)
  [NEW] Feature/custom oauth mail field and interpolation for mapped fields (#15690)
  [FIX] "Invalid Invite" message when registration is disabled (#17226)
  [FIX] Red color error outline is not removed after password update (#16536)
  [FIX] Change wording to start DM from info panel (#8799)
  New hooks for RouterContext (#17305)
  [FIX] SAML assertion signature enforcement (#17278)
  [FIX] LDAP users lose session on refresh (#17302)
  [NEW] Add MMS support to Voxtelesys (#17217)
  [FIX] Popover component doesn't have scroll (#17198)
  [FIX] Omnichannel SMS / WhatsApp integration errors due to missing location data (#17288)
  [FIX] User search on directory not working correctly (#17299)
  [FIX] Can not save Unread Tray Icon Alert user preference (#16288) (#16313)
  [FIX] Variable rendering problem on Import recent history page (#15997)
  [FIX] Admin panel custom sounds, multiple sound playback fix and added single play/pause button (#16215)
  [FIX] Discussions created from inside DMs were not working (#17282)
  [FIX] translation for nl (#16742)
  [FIX] No maxlength defined for custom user status (#16534)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

@ggazzo ggazzo ggazzo approved these changes

@HammyHavoc HammyHavoc HammyHavoc left review comments

@engelgabriel engelgabriel Awaiting requested review from engelgabriel

@karlprieb karlprieb Awaiting requested review from karlprieb

Assignees

@ggazzo ggazzo

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bryandesrosiers @HammyHavoc @geekgonecrazy @sampaiodiego @CLAassistant @ggazzo @engelgabriel