Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Xenforo [BD]API for 'user.user_id; instead of 'id' #8968

Merged
merged 3 commits into from
Dec 4, 2017
Merged

[FIX] Xenforo [BD]API for 'user.user_id; instead of 'id' #8968

merged 3 commits into from
Dec 4, 2017

Conversation

wesnspace
Copy link
Contributor

For users of XenForo forums using [BD]API plugin for Custom OAuth services, this change will ensure the proper arguments are passed to complete the authentication process. This was provided by user HallyNoona on XenForo community threads at https://xenforo.com/community/threads/bd-api.48900/page-19

@wesnspace
Fix for Xenforo [BD]API for 'user.user_id; instead of 'id'
5898ff1 
For users of XenForo forums using [BD]API plugin for Custom OAuth services, this change will ensure the proper arguments are passed to complete the authentication process. This was provided by user HallyNoona on XenForo community threads at https://xenforo.com/community/threads/bd-api.48900/page-19
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

graywolf336
graywolf336 suggested changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes, as a former user of Xenforo and [BD]API it is exciting to see this. Do you mind fixing the code linting so that it's the same as the rest of the project? Thanks again!

@RocketChat RocketChat deleted a comment Nov 29, 2017
@RocketChat RocketChat deleted a comment Nov 29, 2017
@wesnspace
Copy link
Contributor Author

Should be good to go now. Thanks for your patience as I learn how to use Github.

graywolf336
graywolf336 approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@graywolf336 graywolf336 added this to the 0.60.0 milestone Nov 29, 2017
@rodrigok rodrigok merged commit c6b7fb7 into RocketChat:develop Dec 4, 2017
@wesnspace wesnspace deleted the patch-2 branch December 4, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graywolf336 graywolf336 graywolf336 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wesnspace @CLAassistant @graywolf336 @rodrigok