Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Save room's last message #8979

Merged
merged 11 commits into from
Dec 4, 2017
Merged

[NEW] Save room's last message #8979

merged 11 commits into from
Dec 4, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

It closes #8383 since the lastMessage field is also returned from im.list, channels.list and groups.list REST APIs.

The feature is turned off by default and can be activated via admin panel:
image

This is how it looks on web when turned on:
image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8979 November 29, 2017 17:48 Inactive
@geekgonecrazy
Copy link
Contributor

😍 that screenshot is killer with a John Doe user and his very own avatar. 😁

@geekgonecrazy
Copy link
Contributor

Ok I gotta ask. What happens if If the last message is massive?

@sampaiodiego
Copy link
Member Author

Ok I gotta ask. What happens if If the last message is massive?

@geekgonecrazy it will be all rendered but hidden via CSS 🤔

@graywolf336
Copy link
Contributor

it will be all rendered but hidden via CSS 🤔

Do you think there should be a character limit? For performance reasons? 🤔

@rodrigok rodrigok merged commit 81f9637 into develop Dec 4, 2017
@rodrigok rodrigok added this to the 0.60.0 milestone Dec 4, 2017
@rodrigok rodrigok deleted the save-last-message branch December 18, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API to pull unread messages
6 participants