[BREAK] Decouple livechat visitors from regular users #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make Meteor ignore changes on this folder which will prevent rebuilds of whole livechat package. For local development it is recommended to run the livechat app individually like on run.sh file.
ggazzo
approved these changes
Dec 21, 2017
sampaiodiego
added a commit
that referenced
this pull request
Jan 20, 2018
This was caused by #9048 due to a result schema change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7725
This is a big change which will help a lot instances using livechat. Removing livechat visitors from regular
userscollection will help rocket.chat run lighter and also allows livechat visitors to become regular rocket.chat users.I had to change presence packages to allow it to work without a logged in users, so now if you tell it to track a connection it emits events when that connection changes its status.
I had to also change a few on our streams so it allows livechat visitors to listen some streams which were previously only for logged in users.
This PR also includes a migration so all current livechat users will be moved to the new visitors collection on the first startup.
I added a
[BREAK]tag due to the schema changing and a few real-time APIs I had to change.