Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.60.4 #9377

Merged
merged 11 commits into from
Jan 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM rocketchat/base:8

ENV RC_VERSION 0.60.3
ENV RC_VERSION 0.60.4

MAINTAINER buildmaster@rocket.chat

Expand Down
2 changes: 1 addition & 1 deletion .sandstorm/sandstorm-pkgdef.capnp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const pkgdef :Spk.PackageDefinition = (

appVersion = 62, # Increment this for every release.

appMarketingVersion = (defaultText = "0.60.3"),
appMarketingVersion = (defaultText = "0.60.4"),
# Human-readable representation of appVersion. Should match the way you
# identify versions of your app in documentation and marketing.

Expand Down
2 changes: 1 addition & 1 deletion .travis/snap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ elif [[ $TRAVIS_TAG ]]; then
RC_VERSION=$TRAVIS_TAG
else
CHANNEL=edge
RC_VERSION=0.60.3
RC_VERSION=0.60.4
fi

echo "Preparing to trigger a snap release for $CHANNEL channel"
Expand Down
53 changes: 53 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,56 @@
<a name="0.60.4"></a>
## 0.60.4 (2018-01-10)


### Bug Fixes

- [#9343](https://github.com/RocketChat/Rocket.Chat/pull/9343) LDAP TLS not working in some cases
- [#9330](https://github.com/RocketChat/Rocket.Chat/pull/9330) announcement hyperlink color
- [#9335](https://github.com/RocketChat/Rocket.Chat/pull/9335) Deleting message with store last message not removing
- [#9345](https://github.com/RocketChat/Rocket.Chat/pull/9345) last message cutting on bottom
- [#9328](https://github.com/RocketChat/Rocket.Chat/pull/9328) popover on safari for iOS
- [#9364](https://github.com/RocketChat/Rocket.Chat/pull/9364) Highlight setting not working correctly

<details>
<summary>Others</summary>

- [#9346](https://github.com/RocketChat/Rocket.Chat/pull/9346) Update Marked dependecy to 0.3.9
</details>


<details>
<summary>Details</summary>
<a name="0.60.4-rc.1"></a>
## 0.60.4-rc.1 (2018-01-08)


### Bug Fixes

- [#9330](https://github.com/RocketChat/Rocket.Chat/pull/9330) announcement hyperlink color
- [#9335](https://github.com/RocketChat/Rocket.Chat/pull/9335) Deleting message with store last message not removing
- [#9345](https://github.com/RocketChat/Rocket.Chat/pull/9345) last message cutting on bottom
- [#9328](https://github.com/RocketChat/Rocket.Chat/pull/9328) popover on safari for iOS


<details>
<summary>Others</summary>

- [#9346](https://github.com/RocketChat/Rocket.Chat/pull/9346) Update Marked dependecy to 0.3.9
</details>



<a name="0.60.4-rc.0"></a>
## 0.60.4-rc.0 (2018-01-05)


### Bug Fixes

- [#9343](https://github.com/RocketChat/Rocket.Chat/pull/9343) LDAP TLS not working in some cases

</details>


<a name="0.60.3"></a>
## 0.60.3 (2018-01-03)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Rocket.Chat",
"description": "The Ultimate Open Source WebChat Platform",
"version": "0.60.3",
"version": "0.60.4",
"author": {
"name": "Rocket.Chat",
"url": "https://rocket.chat/"
Expand Down
5 changes: 5 additions & 0 deletions packages/rocketchat-cors/cors.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import _ from 'underscore';

import url from 'url';

import tls from 'tls';
// FIX For TLS error see more here https://github.com/RocketChat/Rocket.Chat/issues/9316
// TODO: Remove after NodeJS fix it, more information https://github.com/nodejs/node/issues/16196 https://github.com/nodejs/node/pull/16853
tls.DEFAULT_ECDH_CURVE = 'auto';

WebApp.rawConnectHandlers.use(Meteor.bindEnvironment(function(req, res, next) {
if (req._body) {
return next();
Expand Down
2 changes: 1 addition & 1 deletion packages/rocketchat-lib/rocketchat.info
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "0.60.3"
"version": "0.60.4"
}
7 changes: 5 additions & 2 deletions packages/rocketchat-lib/server/functions/deleteMessage.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,11 @@ RocketChat.deleteMessage = function(message, user) {

// update last message
if (RocketChat.settings.get('Store_Last_Message')) {
const lastMessage = RocketChat.models.Messages.getLastMessageSentWithNoTypeByRoomId(message.rid);
RocketChat.models.Rooms.setLastMessageById(message.rid, lastMessage);
const room = RocketChat.models.Rooms.findOneById(message.rid, { fields: { lastMessage: 1 } });
if (!room.lastMessage || room.lastMessage._id === message._id) {
const lastMessage = RocketChat.models.Messages.getLastVisibleMessageSentWithNoTypeByRoomId(message.rid, message._id);
RocketChat.models.Rooms.setLastMessageById(message.rid, lastMessage);
}
}

if (showDeletedStatus) {
Expand Down
7 changes: 6 additions & 1 deletion packages/rocketchat-lib/server/models/Messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,17 @@ RocketChat.models.Messages = new class extends RocketChat.models._Base {
return this.findOne(query);
}

getLastMessageSentWithNoTypeByRoomId(rid) {
getLastVisibleMessageSentWithNoTypeByRoomId(rid, messageId) {
const query = {
rid,
_hidden: { $ne: true },
t: { $exists: false }
};

if (messageId) {
query._id = { $ne: messageId };
}

const options = {
sort: {
ts: -1
Expand Down
6 changes: 3 additions & 3 deletions packages/rocketchat-markdown/.npm/package/npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/rocketchat-markdown/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Package.describe({
});

Npm.depends({
'marked': '0.3.6'
'marked': '0.3.9'
});

Package.onUse(function(api) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@

cursor: pointer;

user-select: none;

color: var(--popover-item-color);

font-size: var(--popover-item-text-size);
Expand Down Expand Up @@ -128,6 +130,10 @@
margin: 8px !important;

animation: dropup-show 0.3s cubic-bezier(0.45, 0.05, 0.55, 0.95);

&--safariIos {
bottom: initial;
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
line-height: normal;

& .emojione,
& .emoji, {
& .emoji {
width: 13px !important;
min-width: 13px;
height: 13px !important;
Expand Down
6 changes: 6 additions & 0 deletions packages/rocketchat-theme/client/imports/general/base_old.css
Original file line number Diff line number Diff line change
Expand Up @@ -1742,6 +1742,12 @@
& ~ .container-bars {
top: 45px;
}

a {
text-decoration: underline;

color: currentColor;
}
}

.rc-old .cms-page {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Template.accountPreferences.helpers({
},
highlights() {
const userHighlights = RocketChat.getUserPreference(Meteor.user(), 'highlights');
return userHighlights ? userHighlights.join(', ') : undefined;
return userHighlights ? userHighlights.join('\n') : undefined;
},
desktopNotificationEnabled() {
return KonchatNotification.notificationStatus.get() === 'granted' || (window.Notification && Notification.permission === 'granted');
Expand Down
2 changes: 1 addition & 1 deletion packages/rocketchat-ui/client/views/app/popover.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template name="popover">
<div class="rc-popover rc-popover--{{popoverClass}}" data-popover="popover" style="display:block;">
<div class="rc-popover__content">
<div class="rc-popover__content {{#if isSafariIos}}rc-popover__content--safariIos{{/if}}">
{{#each column in columns}}
<div class="rc-popover__column">
{{#each group in column.groups}}
Expand Down
4 changes: 4 additions & 0 deletions packages/rocketchat-ui/client/views/app/popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,7 @@ Template.popover.events({
}
}
});

Template.popover.helpers({
isSafariIos: /iP(ad|hone|od).+Version\/[\d\.]+.*Safari/i.test(navigator.userAgent)
});