Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all npm from meteor packages to package.json & Update versions #9395

Merged
merged 3 commits into from
Jan 18, 2018
Merged

Move all npm from meteor packages to package.json & Update versions #9395

merged 3 commits into from
Jan 18, 2018

Conversation

engelgabriel
Copy link
Member

@engelgabriel engelgabriel commented Jan 12, 2018 •
edited by rodrigok
Loading

Should close #9418

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9395 January 12, 2018 02:23 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9395 January 12, 2018 03:00 Inactive
@engelgabriel engelgabriel requested a review from rodrigok January 12, 2018 03:15
@engelgabriel engelgabriel added this to the 0.61.0 milestone Jan 12, 2018
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9395 January 13, 2018 17:55 Inactive
@rodrigok rodrigok changed the title updating dependencies Move all npm from meteor packages to package.json & Update versions Jan 13, 2018
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9395 January 13, 2018 18:32 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9395 January 13, 2018 19:04 Inactive
sampaiodiego
sampaiodiego previously requested changes Jan 15, 2018
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this one was not removed?

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-9395 January 17, 2018 16:12 Inactive
@ggazzo ggazzo self-requested a review January 18, 2018 19:08
@rodrigok rodrigok merged commit 54d09e7 into develop Jan 18, 2018
@rodrigok rodrigok deleted the dep-update branch January 18, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego sampaiodiego left review comments

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.61.0
Development

Successfully merging this pull request may close these issues.
4 participants
@engelgabriel @ggazzo @sampaiodiego @rodrigok