-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add user settings / preferences API endpoint #9457
Merged
rodrigok
merged 30 commits into
RocketChat:develop
from
jgtoriginal:userPrefsEndPountRestAPI
Feb 21, 2018
Merged
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1b8483f
Add user settings / preferences API endpoint #8694
jgtoriginal f30d581
Thx coday bot: missing semicolons
jgtoriginal 28b2993
Thx coday bot: property shorthand expected
jgtoriginal c8f843b
unneded ;
jgtoriginal b2c75b4
making tests happy
jgtoriginal c5c2042
updating mongo
jgtoriginal 01f499f
missing semicolon
jgtoriginal e0c2b8f
formatting
jgtoriginal c99bfcc
formatting
jgtoriginal c797214
formatting
jgtoriginal 4cc4c48
formatting
jgtoriginal 3c5077a
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
jgtoriginal d0d7f59
users.getPreferences always requires authentication
jgtoriginal 1df340e
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
jgtoriginal 58d744f
fixing conflicts
jgtoriginal e336ddb
going by single quotes
jgtoriginal cee2461
default to the user registered if none is passed
jgtoriginal b3295a5
adding new params requested by @karlprieb
jgtoriginal f203b27
get own preferences only
jgtoriginal 9adf9fc
adding muteFocusedConversations param on @karlprieb request
jgtoriginal 2db5a94
giving a more sensible error message
jgtoriginal e36f95d
replacing this.getUserFromParams() for this.userId, due to legit secu…
jgtoriginal c964116
fixing typo on i18n
jgtoriginal 3132664
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
jgtoriginal 82e9c42
Merge branch 'DeprecationWarning' into userPrefsEndPountRestAPI
jgtoriginal 5871eb8
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
jgtoriginal 19a8ad6
added findOne call to retrieve the user, and remove verification whic…
MarcosSpessatto d81d1f7
added tests for this endpoint
MarcosSpessatto 68ceaf7
fix test about getPreferences endpoint
MarcosSpessatto 6e47d51
Merge branch 'develop' into userPrefsEndPountRestAPI
rodrigok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgtoriginal did you tested this? You will need to execute a find to get the user's object when you have the user's id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigok no worries, will get to it at some point today and let you know.
Thanks very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been solved by @MarcosSpessatto on 19a8ad6