Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPM package-lock inside livechat #9504

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Prevent NPM package-lock inside livechat #9504

merged 1 commit into from
Jan 25, 2018

Conversation

rodrigok
Copy link
Member

@RocketChat/core

Closes #9499

@rodrigok rodrigok added this to the 0.61.0 milestone Jan 25, 2018
@rodrigok rodrigok requested a review from sampaiodiego January 25, 2018 17:16
@sampaiodiego
Copy link
Member

testing this I get:
npm notice created a lockfile as package-lock.json. You should commit this file.
🤷‍♂️

@rodrigok rodrigok merged commit 59487fe into develop Jan 25, 2018
@rodrigok rodrigok deleted the hotfix/livechat-npm-fix branch January 25, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.61.0
Development

Successfully merging this pull request may close these issues.

npm ERR! Cannot read property '0' of undefined when starting Rocket Chat server
3 participants
@rodrigok @sampaiodiego @engelgabriel