[NEW] Allow configuration of SAML logout behavior #9527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimpson
changed the title
|
replacement for the corrupted #9524 |
|
Should we consider updating our fork of the original files from https://github.com/steffow/meteor-accounts-saml ? |
|
huh? any reason my linting is not respecting |
mrsimpson
force-pushed
the
core/#9522-saml-logout
branch
from
ed2310b to
4b59d4e
Compare
mrsimpson
force-pushed
the
core/#9522-saml-logout
branch
from
023a152 to
0e53a9c
Compare
rodrigok
force-pushed
the
core/#9522-saml-logout
branch
from
bd51476 to
d20c0bd
Compare
# Conflicts: # package-lock.json
rodrigok
force-pushed
the
core/#9522-saml-logout
branch
from
d20c0bd to
6f13cf9
Compare
rodrigok
approved these changes
Feb 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
This PR addresses a TODO in the current implementation of the SAML logout handling. It allows the admin to configure what should happen once a user logged-in via SAML logs out: whether the SAML session or only the Rocket.Chat-session be terminated.
Closes #9522
Decided to make it configurable not with a boolean value, but with a select.
This allows for more flexibility handling the logout, e. g. asking the user what he'd like to log-off from.