Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Parse inline code without space before initial backtick #9754

Merged
merged 7 commits into from
Jul 5, 2018

Conversation

c0dzilla
Copy link
Contributor

@RocketChat/core

Modified regex in matching function.
Closes #9553

Earlier:
earlier_parse

Now:
fixed_parse

@c0dzilla
Copy link
Contributor Author

The test that it is failing is checking exactly what #9553 complains about.

image

Is there some reason why the regex has been written like this that I'm unaware of? Or should the test be modified?

@c0dzilla
Copy link
Contributor Author

@geekgonecrazy is there some reason why the test is checking that inline code without initial space is not parsed?

@geekgonecrazy
Copy link
Contributor

I'm not sure. Feel free to adjust the test to test the functionality if that's not enough to fully test

@c0dzilla
Copy link
Contributor Author

@geekgonecrazy I've modified the test.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9754 April 18, 2018 19:54 Inactive
@gdelavald gdelavald self-assigned this Apr 18, 2018
@RocketChat RocketChat deleted a comment Apr 18, 2018
@gdelavald gdelavald temporarily deployed to rocket-chat-pr-9754 April 18, 2018 20:30 Inactive
gdelavald
gdelavald previously approved these changes Apr 18, 2018
Copy link
Contributor

@gdelavald gdelavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9754 April 18, 2018 23:24 Inactive
@ggazzo ggazzo added the ui/ux label Jul 3, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jul 3, 2018
@ggazzo ggazzo merged commit ae150fb into RocketChat:develop Jul 5, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline code test/test not parsed correctly
6 participants