[NEW] 2 Factor Authentication when using OAuth and SAML #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hudell
changed the title
graywolf336
added a commit
that referenced
this pull request
Apr 17, 2018
|
Let’s make sure this works on mobile apps before merging |
Hudell
force-pushed
the
2fa-for-all-authenticators
branch
from
7ecbd85 to
f8d1a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Issue #6750
This PR implements 2 Factor Authentication on all OAuth methods. Also includes 2FA for SAML authentication.
This PR includes the changes made on PR #10084 since they were needed for SAML to work properly.
It is ready to be merged, but we are waiting until the mobile apps add support to 2fa.