[FIX] Parsing messages with multiple markdown matches ignore some tokens #9884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9854 #9758
The message body was containing a random string of the form '=!=randomInteger=!=' many times whenever the message had multiple markdown matches(for example a url with inline code). This was because the tokens were being unmounted in the order in which they were attached during parsing, leading to misses when a token was overwritten by another token as in the case of mutiple matches. This pr changes unmounting order to LIFO to fix this.
Example:
now parsed as