Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Overlapping header in user profile panel #9889

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Regression: Overlapping header in user profile panel #9889

merged 1 commit into from
Feb 26, 2018

Conversation

kaiiiiiiiii
Copy link
Contributor

@RocketChat/core

Before:
screen shot 2018-02-24 at 18 42 01

After:
screen shot 2018-02-24 at 18 41 29

kumarcs
kumarcs reviewed Feb 24, 2018
View reviewed changes
Copy link
Contributor

@kumarcs kumarcs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overlay removing is required
i mean yes you did right

@kaiiiiiiiii kaiiiiiiiii changed the title [FIX] Overlay in user profile panel [FIX] Overlapping header in user profile panel Feb 24, 2018
@rodrigok rodrigok requested review from ggazzo and karlprieb February 26, 2018 13:44
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 26, 2018
@rodrigok rodrigok changed the title [FIX] Overlapping header in user profile panel Regression: Overlapping header in user profile panel Feb 26, 2018
@rodrigok rodrigok merged commit a7f05b1 into RocketChat:develop Feb 26, 2018
@kaiiiiiiiii kaiiiiiiiii deleted the fix_overlay_in_user_profile_panel branch February 26, 2018 17:19
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarcs kumarcs kumarcs left review comments

@karlprieb karlprieb karlprieb approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kaiiiiiiiii @karlprieb @kumarcs @rodrigok @engelgabriel