Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow inviting other agents to the same LiveChat room #9903

Closed
wants to merge 19 commits into from

Conversation

renatobecker-zz
Copy link

@renatobecker-zz renatobecker-zz commented Feb 26, 2018

@RocketChat/core

Closes #9822
Closes #8234
Closes #8235

This fix allows to invite other agents to join the same current chat.
Now, we are using the _id property as a route parameter, instead of using the code property.
So the room link can be shared with other agents.

Additional information:
When a new agent accepts the invitation to participate in a LiveChat room, the visitor will no longer be notified.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 February 26, 2018 19:23 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 February 26, 2018 19:39 Inactive
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@RocketChat RocketChat deleted a comment Feb 26, 2018
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-9903 March 6, 2018 22:18 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was too deep testing this that I sent a fix for:

  • using a livechat agent without admin privilegies I was unable to /invite another user. fixed by 70f8833

but the following are still changes I would like to be made:

  • link to previous chats are not working (still using code)
  • there are references to the deprecated code field across the code base.

- link to previous chats are not working (still using code);
- there are references to the deprecated code field across the code base;
- added migration to remove an index from the rocketchat_subscription collection.
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 March 8, 2018 16:14 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 March 13, 2018 13:51 Inactive
@sampaiodiego sampaiodiego added this to the 0.64.0 milestone Apr 3, 2018
@renatobecker-zz renatobecker-zz modified the milestones: 0.64.0, 0.65.0 May 2, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 21, 2018 18:08 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 22, 2018 01:27 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 22, 2018 02:13 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 22, 2018 16:44 Inactive
@rodrigok rodrigok modified the milestones: 0.65.0, 0.66.0 May 22, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 23, 2018 00:02 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 24, 2018 12:18 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 24, 2018 13:27 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9903 May 30, 2018 13:02 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants