Changed 'confirm password' placeholder text on user registration form #9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
graywolf336
previously requested changes
Mar 2, 2018
| @@ -85,7 +85,7 @@ <h2 data-i18n="Registration_Succeeded">{{{_ "Registration_Succeeded"}}}</h2> | |||
| <div class="rc-input__wrapper"> | |||
| <input name="confirm-pass" id="confirm-pass" type="password" class="rc-input__element" | |||
| autocapitalize="off" autocorrect="off" | |||
| placeholder="{{passwordPlaceholder}}" autofocus> | |||
| placeholder="Confirm Password" autofocus> | |||
There was a problem hiding this comment.
Please do not remove any i18n and instead add an additional place. And please remove the package-lock.json file changes.
There was a problem hiding this comment.
sorry, but I'm new in open Source. Could you please describe what do you mean by add an additional place and is my approach correct
There was a problem hiding this comment.
should I add the same for confirm password here in the form.js file in same folder. on the other hand there are many i18n files which one to use
There was a problem hiding this comment.
Search for "passwordPlaceholder" in your editor to get a good start:
|
please review this pull request |
kumarcs
commented
Mar 5, 2018
| @@ -85,7 +85,7 @@ <h2 data-i18n="Registration_Succeeded">{{{_ "Registration_Succeeded"}}}</h2> | |||
| <div class="rc-input__wrapper"> | |||
| <input name="confirm-pass" id="confirm-pass" type="password" class="rc-input__element" | |||
| autocapitalize="off" autocorrect="off" | |||
| placeholder="{{passwordPlaceholder}}" autofocus> | |||
| placeholder="Confirm Password" autofocus> | |||
There was a problem hiding this comment.
I have done that i think, please review it
|
please consider these changes
…On Sat, Mar 3, 2018 at 11:18 PM, Codacy Bot ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/rocketchat-ui-login/client/login/form.js
<#9969 (comment)>
:
> @@ -58,6 +58,9 @@ Template.loginForm.helpers({
passwordPlaceholder() {
return RocketChat.settings.get('Accounts_PasswordPlaceholder') || t('Password');
},
+ confirmPasswordPlaceholder(){
[image: Codacy]
<https://camo.githubusercontent.com/b72992711a855bd9a03bfbdfc5ef7fcf528482f5/68747470733a2f2f6170702e636f646163792e636f6d2f6173736574732f696d616765732f66617669636f6e2e706e67>
Issue found: Missing space before opening brace. (space-before-blocks)
<https://app.codacy.com/app/RocketChat/Rocket-Chat/pullRequest?prid=1388900>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9969 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYyB0LgAOk9y6oygRFelMjVWSFkPiv1rks5tateDgaJpZM4SZbop>
.
|
ggazzo
changed the title
|
hey @kumarnitj thanks for your contribution, I made some changes in your PR, I thought you wouldn't matter about that. |
ggazzo
approved these changes
Jun 6, 2018
engelgabriel
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:-
after:-
