Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Keyed children #231

Merged
merged 9 commits into from
Jun 4, 2020
Merged

perf: Keyed children #231

merged 9 commits into from
Jun 4, 2020

Conversation

tassoevan
Copy link
Collaborator

Depends on #230
React.Children doesn't provide a way to perform flat mapping in children elements (i.e. ignoring null-like values and React.Fragment elements).

@tassoevan tassoevan requested a review from a team May 11, 2020 05:20
@ggazzo ggazzo merged commit 8b63483 into develop Jun 4, 2020
@ggazzo ggazzo deleted the perf/keyed-children branch June 4, 2020 00:58
gabriellsh added a commit that referenced this pull request Jun 4, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage …
b21d608 
…into new/playground

* 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage:
  feat: MP3 encoder (#235)
  fix: Missing legacy icons (#238)
  perf: Keyed children (#231)
  feat: Updated icons (#188)
  perf: Generated classNames from props (#230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo