Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Location in typesVersions field #449

Merged
merged 1 commit into from
May 7, 2021
Merged

fix: Location in typesVersions field #449

merged 1 commit into from
May 7, 2021

Conversation

tassoevan
Copy link
Collaborator

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

As Rocket.Chat is currently using TypeScript 3.9, the misconfiguration of typesVersions in @rocket.chat/string-helpers made the package invisible to tsc.

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team May 7, 2021 03:09
@tassoevan tassoevan merged commit 164e1c1 into develop May 7, 2021
@tassoevan tassoevan deleted the fix/string-helpers-types-versions branch May 7, 2021 03:46
ggazzo pushed a commit that referenced this pull request May 18, 2021
@tassoevan @ggazzo
fix: Location in typesVersions field (#449)
0bc2c38
ggazzo pushed a commit that referenced this pull request May 18, 2021
@tassoevan @ggazzo
fix: Location in typesVersions field (#449)
491f98b
This was referenced Sep 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 string-helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo