Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update icon building readme #472

Merged
merged 1 commit into from
Jun 21, 2021
Merged

chore: Update icon building readme #472

merged 1 commit into from
Jun 21, 2021

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 17, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@dougfabris dougfabris requested a review from a team June 17, 2021 18:25
@ggazzo ggazzo merged commit faf7de3 into develop Jun 21, 2021
@ggazzo ggazzo deleted the chore/icons-readme branch June 21, 2021 13:04
gabriellsh added a commit that referenced this pull request Jun 23, 2021
….Chat.Fuselage into new/image-manipulation

* 'new/image-manipulation' of github.com:RocketChat/Rocket.Chat.Fuselage:
  Update tsconfig.json
  chore: Update icon building readme (#472)
  fix: Menu component and options.label prop type (#476)
  fix: endReached prop in _Options of PaginatedSelectFiltered Component (#475)
  fix: Export MultiSelect component in .d.ts file (#473)
  feat(ui-kit): Attachment Surface (#474)
  fix(fuselage): Fuselage production build (#477)
  feat: onboarding-ui package (#463)
  fix(eslint): Add missing ESLint rule for TypeScript (#470)
  fix(string-helpers):  typesVersions (#469)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants