Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forwarding ref in Select components #492

Merged
merged 2 commits into from
Jul 8, 2021
Merged

fix: Forwarding ref in Select components #492

merged 2 commits into from
Jul 8, 2021

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jul 8, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

It forward refs to the anchors of Select and MultiSelect components.

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team July 8, 2021 15:30
@tassoevan tassoevan merged commit 6c360bd into develop Jul 8, 2021
@tassoevan tassoevan deleted the fix/select branch July 8, 2021 17:34
gabriellsh added a commit that referenced this pull request Jul 8, 2021
…into wizard/server_reg_form

* 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage:
  fix: Forwarding ref in Select components (#492)
gabriellsh added a commit that referenced this pull request Aug 13, 2021
…into new/image-manipulation

* 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: (23 commits)
  fix: modal styles
  feat(onboarding-ui): Create Cloud Workspace Form (#499)
  Pass style-loader output into babel-loader
  Check ES version after bundling Fuselage
  fix(onboarding-ui): Labels wrapping under checkbox (#509)
  chore(fuselage): Nested sidebar props type (#510)
  feat(onboarding-ui): Request trial form (#505)
  v0.28.0
  fix: Missing Sidebar type (#506)
  fix: Missing Sidebar type (#506)
  docs(github): Update pull request template (#504)
  fix: Escape trademark sign (#500)
  feat(onboarding-ui): AdminInfoPage for Cloud Registration wizard (#497)
  feat(onboarding-ui): Self-hosted registration (#501)
  fix: Add Tab.Item definition (#503)
  fix tabs.d.ts (#502)
  feat(onboarding-ui): Invalid Link page (#496)
  feat(onboarding-ui): Server registration form (#494)
  feat(onboarding-ui): Administrator information form and Organization information form (#489)
  fix: Forwarding ref in Select components (#492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants